Little haXeVideo patch

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Little haXeVideo patch

Juan Delgado
Hi there,

To integrate with Hippo I'd like to modify the path to where videos
are saved in haXeVideo and currently it seems to be harcoded to a
relative path "videos/". I've created a little patch to revision 36 to
allow passing an extra parameter. Nicolas, could you please take a
look and integrate if you think it's ok? Maybe there's a better way.

Also, I'm starting the server like this:

p = new Process('neko',["server","localhost","1935"]);

Haven't tried on Windows yet, but at least in Leopard the neko process
remains open after closing the SWHX window. How can I finish a
process? According to the docs, there's a close() method, but it's not
present in haXe 2.0.1. Is this a bug or just that the docs are out of
sync? Calling p.exitCode() doesn't help either.

Thanks!

Juan

--
Juan Delgado - Zárate
http://zarate.tv
http://dandolachapa.com
http://loqueyosede.com

--
haXe - an open source web programming language
http://haxe.org

Serverhx.patch (914 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Little haXeVideo patch

Nicolas Cannasse
Juan Delgado a écrit :

> Hi there,
>
> To integrate with Hippo I'd like to modify the path to where videos
> are saved in haXeVideo and currently it seems to be harcoded to a
> relative path "videos/". I've created a little patch to revision 36 to
> allow passing an extra parameter. Nicolas, could you please take a
> look and integrate if you think it's ok? Maybe there's a better way.
>
> Also, I'm starting the server like this:
>
> p = new Process('neko',["server","localhost","1935"]);
>
> Haven't tried on Windows yet, but at least in Leopard the neko process
> remains open after closing the SWHX window. How can I finish a
> process? According to the docs, there's a close() method, but it's not
> present in haXe 2.0.1. Is this a bug or just that the docs are out of
> sync? Calling p.exitCode() doesn't help either.

The problem is that haXeVideo will never exit by itself, and there is no
way to kill a process using Neko API. Maybe that's a good addition for
systools ?

Nicolas

--
haXe - an open source web programming language
http://haxe.org
Reply | Threaded
Open this post in threaded view
|

Re: Little haXeVideo patch

Juan Delgado
I really don't mind provided I can stop it : )

Just out of curiosity, why adding the stop mechanism to Systools and
not to neko.io.process itself? It sounds a little bit odd starting the
process in one place and stop it somewhere else completely different.

Cheers!

Juan

On Sun, Nov 2, 2008 at 8:48 AM, Nicolas Cannasse
<[hidden email]> wrote:

> Juan Delgado a écrit :
>>
>> Hi there,
>>
>> To integrate with Hippo I'd like to modify the path to where videos
>> are saved in haXeVideo and currently it seems to be harcoded to a
>> relative path "videos/". I've created a little patch to revision 36 to
>> allow passing an extra parameter. Nicolas, could you please take a
>> look and integrate if you think it's ok? Maybe there's a better way.
>>
>> Also, I'm starting the server like this:
>>
>> p = new Process('neko',["server","localhost","1935"]);
>>
>> Haven't tried on Windows yet, but at least in Leopard the neko process
>> remains open after closing the SWHX window. How can I finish a
>> process? According to the docs, there's a close() method, but it's not
>> present in haXe 2.0.1. Is this a bug or just that the docs are out of
>> sync? Calling p.exitCode() doesn't help either.
>
> The problem is that haXeVideo will never exit by itself, and there is no way
> to kill a process using Neko API. Maybe that's a good addition for systools
> ?
>
> Nicolas
>
> --
> haXe - an open source web programming language
> http://haxe.org
>



--
Juan Delgado - Zárate
http://zarate.tv
http://dandolachapa.com
http://loqueyosede.com

--
haXe - an open source web programming language
http://haxe.org
Reply | Threaded
Open this post in threaded view
|

Re: Little haXeVideo patch

Benjamin Dasnois
I totally agree with Juan on this one :)

On Sun, Nov 2, 2008 at 1:02 PM, Juan Delgado <[hidden email]> wrote:

> I really don't mind provided I can stop it : )
>
> Just out of curiosity, why adding the stop mechanism to Systools and
> not to neko.io.process itself? It sounds a little bit odd starting the
> process in one place and stop it somewhere else completely different.
>
> Cheers!
>
> Juan
>
> On Sun, Nov 2, 2008 at 8:48 AM, Nicolas Cannasse
> <[hidden email]> wrote:
>> Juan Delgado a écrit :
>>>
>>> Hi there,
>>>
>>> To integrate with Hippo I'd like to modify the path to where videos
>>> are saved in haXeVideo and currently it seems to be harcoded to a
>>> relative path "videos/". I've created a little patch to revision 36 to
>>> allow passing an extra parameter. Nicolas, could you please take a
>>> look and integrate if you think it's ok? Maybe there's a better way.
>>>
>>> Also, I'm starting the server like this:
>>>
>>> p = new Process('neko',["server","localhost","1935"]);
>>>
>>> Haven't tried on Windows yet, but at least in Leopard the neko process
>>> remains open after closing the SWHX window. How can I finish a
>>> process? According to the docs, there's a close() method, but it's not
>>> present in haXe 2.0.1. Is this a bug or just that the docs are out of
>>> sync? Calling p.exitCode() doesn't help either.
>>
>> The problem is that haXeVideo will never exit by itself, and there is no way
>> to kill a process using Neko API. Maybe that's a good addition for systools
>> ?
>>
>> Nicolas
>>
>> --
>> haXe - an open source web programming language
>> http://haxe.org
>>
>
>
>
> --
> Juan Delgado - Zárate
> http://zarate.tv
> http://dandolachapa.com
> http://loqueyosede.com
>
> --
> haXe - an open source web programming language
> http://haxe.org
>



--
DASNOIS Benjamin
http://www.benjamindasnois.com

--
haXe - an open source web programming language
http://haxe.org
Reply | Threaded
Open this post in threaded view
|

Re: Little haXeVideo patch

Nicolas Cannasse
>> I really don't mind provided I can stop it : )
>>
>> Just out of curiosity, why adding the stop mechanism to Systools and
>> not to neko.io.process itself? It sounds a little bit odd starting the
>> process in one place and stop it somewhere else completely different.

Well, the idea was that a systools update can be done much more quickly
than waiting for next neko release ;)

Best,
Nicolas

--
haXe - an open source web programming language
http://haxe.org
Reply | Threaded
Open this post in threaded view
|

Re: Little haXeVideo patch

Juan Delgado
Hmmm, I see.

I think I wouldn't trade API consistency for the "quick" systools fix.
However, what time frame are we talking about? 2 weeks, 2 months...?
My next HippoHX release I'd say might be ready in 3-4 weeks depending
on the features I finally include, would that be time enough?

If changes were available on CVS I could try to compile Neko for Mac
and Win myself, although I've never tried.

But again, I really don't mind provided I can stop it!

Thanks,

Juan

On Mon, Nov 3, 2008 at 9:04 AM, Nicolas Cannasse
<[hidden email]> wrote:

>>> I really don't mind provided I can stop it : )
>>>
>>> Just out of curiosity, why adding the stop mechanism to Systools and
>>> not to neko.io.process itself? It sounds a little bit odd starting the
>>> process in one place and stop it somewhere else completely different.
>
> Well, the idea was that a systools update can be done much more quickly than
> waiting for next neko release ;)
>
> Best,
> Nicolas
>
> --
> haXe - an open source web programming language
> http://haxe.org
>



--
Juan Delgado - Zárate
http://zarate.tv
http://dandolachapa.com
http://loqueyosede.com

--
haXe - an open source web programming language
http://haxe.org
Reply | Threaded
Open this post in threaded view
|

Re: Little haXeVideo patch

Nicolas Cannasse
Juan Delgado a écrit :
> Hmmm, I see.
>
> I think I wouldn't trade API consistency for the "quick" systools fix.
> However, what time frame are we talking about? 2 weeks, 2 months...?
> My next HippoHX release I'd say might be ready in 3-4 weeks depending
> on the features I finally include, would that be time enough?

Neko releases are done depending of the amount of changes done and/or in
case of critical bugs. So far there's only been minor changes since
1.8.0 released on 23 September, so don't expect another release before
2-3 months I guess (1.7.1 and 1.8.0 where very near due to massive
changes related to mod_tora and multithread optimizations).

Best,
Nicolas

--
haXe - an open source web programming language
http://haxe.org
Reply | Threaded
Open this post in threaded view
|

Re: Little haXeVideo patch

Juan Delgado
So, any takers to implement this on Systools? I have a nice list of
feature requests regarding Systools if you guys are bored for the
weekend : )

Cheers!

Juan

On Mon, Nov 3, 2008 at 12:50 PM, Nicolas Cannasse
<[hidden email]> wrote:

> Juan Delgado a écrit :
>>
>> Hmmm, I see.
>>
>> I think I wouldn't trade API consistency for the "quick" systools fix.
>> However, what time frame are we talking about? 2 weeks, 2 months...?
>> My next HippoHX release I'd say might be ready in 3-4 weeks depending
>> on the features I finally include, would that be time enough?
>
> Neko releases are done depending of the amount of changes done and/or in
> case of critical bugs. So far there's only been minor changes since 1.8.0
> released on 23 September, so don't expect another release before 2-3 months
> I guess (1.7.1 and 1.8.0 where very near due to massive changes related to
> mod_tora and multithread optimizations).
>
> Best,
> Nicolas
>
> --
> haXe - an open source web programming language
> http://haxe.org
>



--
Juan Delgado - Zárate
http://zarate.tv
http://dandolachapa.com
http://loqueyosede.com

--
haXe - an open source web programming language
http://haxe.org
Reply | Threaded
Open this post in threaded view
|

Re: Little haXeVideo patch

Benjamin Dasnois
Nicolas,

Would you mind adding it to both systools and neko.io.Process ? That
way we would get quick fix and API consistency (which as I think
shouldn't be sacrified to get quick fix)

Regards,

On Mon, Nov 3, 2008 at 2:14 PM, Juan Delgado <[hidden email]> wrote:

> So, any takers to implement this on Systools? I have a nice list of
> feature requests regarding Systools if you guys are bored for the
> weekend : )
>
> Cheers!
>
> Juan
>
> On Mon, Nov 3, 2008 at 12:50 PM, Nicolas Cannasse
> <[hidden email]> wrote:
>> Juan Delgado a écrit :
>>>
>>> Hmmm, I see.
>>>
>>> I think I wouldn't trade API consistency for the "quick" systools fix.
>>> However, what time frame are we talking about? 2 weeks, 2 months...?
>>> My next HippoHX release I'd say might be ready in 3-4 weeks depending
>>> on the features I finally include, would that be time enough?
>>
>> Neko releases are done depending of the amount of changes done and/or in
>> case of critical bugs. So far there's only been minor changes since 1.8.0
>> released on 23 September, so don't expect another release before 2-3 months
>> I guess (1.7.1 and 1.8.0 where very near due to massive changes related to
>> mod_tora and multithread optimizations).
>>
>> Best,
>> Nicolas
>>
>> --
>> haXe - an open source web programming language
>> http://haxe.org
>>
>
>
>
> --
> Juan Delgado - Zárate
> http://zarate.tv
> http://dandolachapa.com
> http://loqueyosede.com
>
> --
> haXe - an open source web programming language
> http://haxe.org
>



--
DASNOIS Benjamin
http://www.benjamindasnois.com

--
haXe - an open source web programming language
http://haxe.org